Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICBC DL lookup, VI incident details page, Remove Autocomplete on input fields #188

Merged
merged 4 commits into from
Nov 1, 2023
Merged

ICBC DL lookup, VI incident details page, Remove Autocomplete on input fields #188

merged 4 commits into from
Nov 1, 2023

Conversation

JustinMacaulay
Copy link
Contributor

covers:

  • DF-2783 Only the DL lookup, Still need a useable licence plate on test for vehicle lookup.
  • DF-2703 renders and correctly populates the incident details on an additional page if requested
  • DF-2760 removed Auto-complete from all basic input fields.

@github-actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-27 18:48:35.230872992 +0000 UTC m=+0.418623204

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@github-actions
Copy link

rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-27 18:50:51.079368919 +0000 UTC m=+0.327399786

redhat
No Vulnerabilities found
No Misconfigurations found

sam-warren
sam-warren approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@sam-warren sam-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JustinMacaulay JustinMacaulay merged commit 42ed1d1 into release/1.0 Nov 1, 2023
5 of 8 checks passed
@JustinMacaulay JustinMacaulay deleted the feature/icbc-lookups branch November 1, 2023 16:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-11-01 16:49:50.564596605 +0000 UTC m=+0.504981767

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-11-01 16:51:24.435519773 +0000 UTC m=+0.306044106

redhat
No Vulnerabilities found
No Misconfigurations found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-warren sam-warren sam-warren approved these changes

@amlanc1 amlanc1 Awaiting requested review from amlanc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinMacaulay @sam-warren